Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 12383051: Change the web socket interface (Closed)

Created:
7 years, 9 months ago by Søren Gjesse
Modified:
7 years, 9 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change the web socket interface The stream of events from a web socket is now the actual messages (text as String and binary as List<int>) instead of instances of MessageEvent. The CloseEvent is reposted as onDone on the stream with the close code and close reason available as properties on the web socket object. Next step is to make the web socket implement IOSink. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19376

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -220 lines) Patch
M sdk/lib/io/websocket.dart View 4 chunks +17 lines, -53 lines 0 comments Download
M sdk/lib/io/websocket_impl.dart View 1 9 chunks +16 lines, -29 lines 0 comments Download
M tests/standalone/io/web_socket_test.dart View 9 chunks +113 lines, -138 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 9 months ago (2013-03-01 14:34:45 UTC) #1
Anders Johnsen
LGTM https://codereview.chromium.org/12383051/diff/1/sdk/lib/io/websocket_impl.dart File sdk/lib/io/websocket_impl.dart (right): https://codereview.chromium.org/12383051/diff/1/sdk/lib/io/websocket_impl.dart#newcode552 sdk/lib/io/websocket_impl.dart:552: //_cleanClose = clean; Outcommented code. https://codereview.chromium.org/12383051/diff/1/sdk/lib/io/websocket_impl.dart#newcode567 sdk/lib/io/websocket_impl.dart:567: //_cleanClose ...
7 years, 9 months ago (2013-03-04 10:29:29 UTC) #2
Søren Gjesse
https://codereview.chromium.org/12383051/diff/1/sdk/lib/io/websocket_impl.dart File sdk/lib/io/websocket_impl.dart (right): https://codereview.chromium.org/12383051/diff/1/sdk/lib/io/websocket_impl.dart#newcode552 sdk/lib/io/websocket_impl.dart:552: //_cleanClose = clean; On 2013/03/04 10:29:29, Anders Johnsen wrote: ...
7 years, 9 months ago (2013-03-04 10:35:18 UTC) #3
Søren Gjesse
7 years, 9 months ago (2013-03-04 10:40:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19376 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698