Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 12383043: Remove wrong type annotation (Closed)

Created:
7 years, 9 months ago by Søren Gjesse
Modified:
7 years, 9 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove wrong type annotation nativeCreateConnect returns either a bool (only true) or an OSError. TBR=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/bin/socket_patch.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 9 months ago (2013-03-01 07:53:02 UTC) #1
Søren Gjesse
Committed patchset #1 manually as r19276 (presubmit successful).
7 years, 9 months ago (2013-03-01 07:53:18 UTC) #2
Anders Johnsen
7 years, 9 months ago (2013-03-01 08:10:02 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698