Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 12382026: Libraries: update VM to current spec (Closed)

Created:
7 years, 9 months ago by hausner
Modified:
7 years, 9 months ago
Reviewers:
Tom Ball
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Libraries: update VM to current spec - Exports allowed in script files - library name is optional - delete meaningless test, file co19 bugs Committed: https://code.google.com/p/dart/source/detail?r=19258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -28 lines) Patch
M runtime/vm/parser.cc View 2 chunks +1 line, -9 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +7 lines, -0 lines 0 comments Download
D tests/language/script_negative_lib.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/language/script_negative_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 9 months ago (2013-02-28 20:36:14 UTC) #1
Tom Ball
lgtm
7 years, 9 months ago (2013-02-28 20:40:25 UTC) #2
hausner
7 years, 9 months ago (2013-02-28 21:17:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19258 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698