Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 12382012: Continue the crazy hacking on the recursive_import_test and give (Closed)

Created:
7 years, 9 months ago by kasperl
Modified:
7 years, 9 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Continue the crazy hacking on the recursive_import_test and give it a proper interceptors library. This is a mess. People that use the compiler API shouldn't have to know about providing the source code for our builtin libraries. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M tests/utils/recursive_import_test.dart View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
7 years, 9 months ago (2013-02-28 08:43:58 UTC) #1
ngeoffray
LGTM
7 years, 9 months ago (2013-02-28 08:47:30 UTC) #2
kasperl
7 years, 9 months ago (2013-02-28 08:48:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19207 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698