Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1238173003: Add a PathFilter to each context in analysis_server (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 8 chunks +28 lines, -2 lines 0 comments Download
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +28 lines, -0 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Cutch
5 years, 5 months ago (2015-07-17 18:34:47 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1238173003/diff/1/pkg/analysis_server/lib/src/context_manager.dart File pkg/analysis_server/lib/src/context_manager.dart (right): https://codereview.chromium.org/1238173003/diff/1/pkg/analysis_server/lib/src/context_manager.dart#newcode334 pkg/analysis_server/lib/src/context_manager.dart:334: return; I think this should be "continue" rather ...
5 years, 5 months ago (2015-07-17 18:44:58 UTC) #3
pquitslund
LGTM https://codereview.chromium.org/1238173003/diff/1/pkg/analysis_server/lib/src/context_manager.dart File pkg/analysis_server/lib/src/context_manager.dart (right): https://codereview.chromium.org/1238173003/diff/1/pkg/analysis_server/lib/src/context_manager.dart#newcode334 pkg/analysis_server/lib/src/context_manager.dart:334: return; On 2015/07/17 18:44:58, Brian Wilkerson wrote: > ...
5 years, 5 months ago (2015-07-17 19:01:13 UTC) #4
Cutch
https://codereview.chromium.org/1238173003/diff/1/pkg/analysis_server/lib/src/context_manager.dart File pkg/analysis_server/lib/src/context_manager.dart (right): https://codereview.chromium.org/1238173003/diff/1/pkg/analysis_server/lib/src/context_manager.dart#newcode334 pkg/analysis_server/lib/src/context_manager.dart:334: return; On 2015/07/17 18:44:58, Brian Wilkerson wrote: > I ...
5 years, 5 months ago (2015-07-17 19:42:33 UTC) #5
Cutch
5 years, 5 months ago (2015-07-17 19:43:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
cb5335dc4a71aa115e3979f23ba2a75959fed704 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698