Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 12381089: Fix for loop variable capturing (Closed)

Created:
7 years, 9 months ago by hausner
Modified:
7 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for loop variable capturing We had a bug in the capturing of for loop variables that only manifested itself if another variable outside the loop was captured as well. Fix for issue 8207 and 8698. Committed: https://code.google.com/p/dart/source/detail?r=19429

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M runtime/vm/parser.cc View 1 4 chunks +14 lines, -14 lines 0 comments Download
M tests/language/block_scope_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 9 months ago (2013-03-04 21:27:52 UTC) #1
srdjan
lgtm
7 years, 9 months ago (2013-03-04 22:28:45 UTC) #2
hausner
7 years, 9 months ago (2013-03-04 22:29:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19429 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698