Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 12381030: Fix stack frame index numbers for full stack traces (Closed)

Created:
7 years, 9 months ago by siva
Modified:
7 years, 9 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix stack frame index numbers for full stack traces It used to be: #0 getCurrentStackTrace (file:///tmp/junk.dart:3:5) #0 func1 (file:///tmp/junk.dart:10:29) #1 func2 (file:///tmp/junk.dart:14:8) #2 func3 (file:///tmp/junk.dart:18:8) #3 func4 (file:///tmp/junk.dart:22:8) #4 main (file:///tmp/junk.dart:26:8) (Notice the two #0 frames on top). Now it will print this as: #0 getCurrentStackTrace (file:///tmp/junk.dart:3:5) #1 func1 (file:///tmp/junk.dart:10:29) #2 func2 (file:///tmp/junk.dart:14:8) #3 func3 (file:///tmp/junk.dart:18:8) #4 func4 (file:///tmp/junk.dart:22:8) #5 main (file:///tmp/junk.dart:26:8) Committed: https://code.google.com/p/dart/source/detail?r=19272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M runtime/lib/stacktrace.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 9 months ago (2013-03-01 02:39:17 UTC) #1
hausner
lgtm
7 years, 9 months ago (2013-03-01 02:55:28 UTC) #2
siva
7 years, 9 months ago (2013-03-01 03:00:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19272 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698