pkg/unittest: Types, deprecations, docs

pkg/unittest: Types, deprecations, docs

Add return types to a number of top-level members
deprecate callbackDone
guardAsync: added types, fixed documentation
- Shouldn't refer to private field in docs

Committed: https://code.google.com/p/dart/source/detail?r=19335

[kevmoo-old, 2013-03-01 03:58:43]

Updated post r19269

[Siggi Cherem (dart-lang), 2013-03-01 17:30:53]

(changed siggi -> sigmund)

[Siggi Cherem (dart-lang), 2013-03-01 17:32:40]

https://codereview.chromium.org/12381016/diff/2001/pkg/unittest/lib/unittest....
File pkg/unittest/lib/unittest.dart (right):

https://codereview.chromium.org/12381016/diff/2001/pkg/unittest/lib/unittest....
pkg/unittest/lib/unittest.dart:726: dynamic guardAsync(Function tryBody,
[Function finallyBody, testNum = -1]) {
- no need to write dynamic here. 
- add 'int' to testNum?

[kevmoo-old, 2013-03-01 18:20:13]

Added 'int'

I know dynamic is not needed, but it's wanted.

Makes reading the source and the docs much more clear.

One can expect a return value if the provided function returns something.

[Siggi Cherem (dart-lang), 2013-03-01 18:21:27]

On 2013/03/01 18:20:13, kevmoo wrote:
> Added 'int'
> 
> I know dynamic is not needed, but it's wanted.
> 
> Makes reading the source and the docs much more clear.
> 
> One can expect a return value if the provided function returns something.

It goes against our style guide =)

http://www.dartlang.org/articles/style-guide/#avoid-annotating-with-dynamic-w...

[kevmoo-old, 2013-03-01 18:32:48]

PTAL

*grumble* style guide *grumble* :-)

[Siggi Cherem (dart-lang), 2013-03-01 18:40:19]

lgtm =)

[kevmoo-old, 2013-03-01 18:45:26]

I lack the bit. Please commit. :-)

[Siggi Cherem (dart-lang), 2013-03-01 18:52:26]

Committed patchset #4 manually as r19335 (presubmit successful).