Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 12381010: dart:io | Remove some test supressions, restore a macos supression section. (Closed)

Created:
7 years, 9 months ago by Bill Hesse
Modified:
7 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Remove some test supressions, restore a macos supression section. BUG=dartbug.com/8795 Committed: https://code.google.com/p/dart/source/detail?r=19214

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M tests/standalone/standalone.status View 1 3 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 9 months ago (2013-02-28 11:52:53 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/12381010/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/12381010/diff/1/tests/standalone/standalone.status#newcode31 tests/standalone/standalone.status:31: [ $runtime == vm ] Combine this with ...
7 years, 9 months ago (2013-02-28 11:57:45 UTC) #2
Bill Hesse
7 years, 9 months ago (2013-02-28 12:14:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19214 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698