Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 12380086: Implement missing functions on ListBase. (Closed)

Created:
7 years, 9 months ago by floitsch
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add tests and update status file. #

Patch Set 3 : Rebase after revert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -14 lines) Patch
M sdk/lib/_collection_dev/list.dart View 1 2 4 chunks +35 lines, -14 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/string_codeunits_test.dart View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
Still missing tests. Depends on CL https://chromiumcodereview.appspot.com/12386072/
7 years, 9 months ago (2013-03-03 00:20:51 UTC) #1
Lasse Reichstein Nielsen
lgtm
7 years, 9 months ago (2013-03-04 09:07:19 UTC) #2
floitsch
7 years, 9 months ago (2013-03-04 13:27:40 UTC) #3
floitsch
Committed patchset #2 manually as r19382 (presubmit successful).
7 years, 9 months ago (2013-03-04 13:28:17 UTC) #4
floitsch
7 years, 9 months ago (2013-03-05 14:03:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r19482 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698