Issue 12380083: Fix a crash in the compiler: we were setting the target of a HInvokeDynamicMethod even if that targ…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12380083: Fix a crash in the compiler: we were setting the target of a HInvokeDynamicMethod even if that targ… (Closed)

Created:
7 years, 9 months ago by ngeoffray

Modified:
7 years, 9 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix a crash in the compiler: we were setting the target of a HInvokeDynamicMethod even if that target did not apply to the selector at the call site. This lead to trying to compile a method that was not resolved. Committed: https://code.google.com/p/dart/source/detail?r=19366

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
	A	tests/language/interceptor6_test.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

7 years, 9 months ago (2013-03-04 07:50:56 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r19366 (presubmit successful).

Expand Messages | Collapse Messages