Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 12380059: Fix type warnings and remove unimplemented stuff from HttpClient interface. (Closed)

Created:
7 years, 9 months ago by Mads Ager (google)
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix type warnings and remove unimplemented stuff from HttpClient interface. R=whesse@google.com,sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -22 lines) Patch
M sdk/lib/io/http.dart View 2 chunks +10 lines, -17 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
7 years, 9 months ago (2013-03-01 12:30:05 UTC) #1
Søren Gjesse
LGTM
7 years, 9 months ago (2013-03-01 12:32:26 UTC) #2
Mads Ager (google)
7 years, 9 months ago (2013-03-01 12:34:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19304 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698