Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 12380058: Remove HBoundedPotentialPrimitiveArray type. (Closed)

Created:
7 years, 9 months ago by kasperl
Modified:
7 years, 9 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove HBoundedPotentialPrimitiveArray type. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19300

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -28 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/types.dart View 5 chunks +11 lines, -18 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/type_mask.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 3 chunks +13 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kasperl
7 years, 9 months ago (2013-03-01 12:14:15 UTC) #1
kasperl
Peter is rightfully concerned that the MockCompiler is turning into something it shouldn't be (it's ...
7 years, 9 months ago (2013-03-01 12:16:54 UTC) #2
ngeoffray
LGTM!
7 years, 9 months ago (2013-03-01 12:26:27 UTC) #3
kasperl
7 years, 9 months ago (2013-03-01 12:30:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19300 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698