Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 12380046: Future-ify all the html methods and add named parameters (Closed)

Created:
7 years, 9 months ago by Emily Fortuna
Modified:
7 years, 9 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Future-ify All the methods! (with a few exceptions we've planned). Also added some tests to test these apis. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19586

Patch Set 1 : #

Total comments: 15

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+871 lines, -174 lines) Patch
M samples/chat/dart_client/chat.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/DataSource.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 28 chunks +334 lines, -62 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 30 chunks +237 lines, -38 lines 0 comments Download
M tests/html/fileapi_test.dart View 1 2 4 chunks +144 lines, -50 lines 0 comments Download
M tests/html/xhr_cross_origin_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/xhr_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/generator.py View 5 chunks +36 lines, -4 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 3 chunks +49 lines, -1 line 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 4 chunks +45 lines, -2 lines 0 comments Download
M tools/dom/scripts/monitored.py View 3 chunks +8 lines, -2 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Emily Fortuna
This removes callbacks from all spots with the exceptions of RAF and setImmediate that we've ...
7 years, 9 months ago (2013-03-06 00:04:44 UTC) #1
blois
https://codereview.chromium.org/12380046/diff/27001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/12380046/diff/27001/sdk/lib/html/dart2js/html_dart2js.dart#newcode26961 sdk/lib/html/dart2js/html_dart2js.dart:26961: + Future openDatabase(String name, String version, String displayName, int ...
7 years, 9 months ago (2013-03-06 00:34:29 UTC) #2
Emily Fortuna
reformatted! ptal https://codereview.chromium.org/12380046/diff/27001/tests/html/fileapi_test.dart File tests/html/fileapi_test.dart (right): https://codereview.chromium.org/12380046/diff/27001/tests/html/fileapi_test.dart#newcode27 tests/html/fileapi_test.dart:27: }).catchError( On 2013/03/06 00:34:29, blois wrote: > ...
7 years, 9 months ago (2013-03-06 21:29:18 UTC) #3
blois
https://codereview.chromium.org/12380046/diff/29001/tests/html/fileapi_test.dart File tests/html/fileapi_test.dart (right): https://codereview.chromium.org/12380046/diff/29001/tests/html/fileapi_test.dart#newcode48 tests/html/fileapi_test.dart:48: .catchError((AsyncError e) { Should still use the test filter ...
7 years, 9 months ago (2013-03-06 21:43:56 UTC) #4
Emily Fortuna
ptal
7 years, 9 months ago (2013-03-06 21:56:06 UTC) #5
blois
lgtm
7 years, 9 months ago (2013-03-06 22:12:53 UTC) #6
Emily Fortuna
7 years, 9 months ago (2013-03-06 22:33:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r19586 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698