Issue 12380042: Don't use package: imports in logging until dartdoc/mirros support them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12380042: Don't use package: imports in logging until dartdoc/mirros support them. (Closed)

Created:
7 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 9 months ago

Reviewers:
Andrei Mouravski

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't use package: imports in logging until dartdoc/mirros support them. Committed: https://code.google.com/p/dart/source/detail?r=19270

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	pkg/logging/lib/logging.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/logging/test/logging_deprecated_test.dart	View	1 chunk	+1 line, -1 line	1 comment	Download
M	pkg/logging/test/logging_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/12380042/diff/1/pkg/logging/test/logging_deprecated_test.dart File pkg/logging/test/logging_deprecated_test.dart (right): https://codereview.chromium.org/12380042/diff/1/pkg/logging/test/logging_deprecated_test.dart#newcode8 pkg/logging/test/logging_deprecated_test.dart:8: import '../../../pkg/logging/lib/logging.dart'; I had to change these too, because ...

7 years, 9 months ago (2013-03-01 00:11:37 UTC) #1

Siggi Cherem (dart-lang)

7 years, 9 months ago (2013-03-01 00:32:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19270 (presubmit successful).

Expand Messages | Collapse Messages