Issue 12380032: Added Socket::SetBlocking() and Socket::SetNonBlocking().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12380032: Added Socket::SetBlocking() and Socket::SetNonBlocking(). (Closed)

Created:
7 years, 9 months ago by Tom Ball

Modified:
7 years, 9 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Added Socket::SetBlocking() and Socket::SetNonBlocking(). Committed: https://code.google.com/p/dart/source/detail?r=19334

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -9 lines)			Patch
M	runtime/bin/socket.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/socket_android.cc	View		4 chunks	+13 lines, -3 lines	0 comments	Download
M	runtime/bin/socket_linux.cc	View		4 chunks	+13 lines, -3 lines	0 comments	Download
M	runtime/bin/socket_macos.cc	View		4 chunks	+13 lines, -3 lines	0 comments	Download
M	runtime/bin/socket_win.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/12380032/diff/1/runtime/bin/socket.h File runtime/bin/socket.h (right): https://codereview.chromium.org/12380032/diff/1/runtime/bin/socket.h#newcode55 runtime/bin/socket.h:55: static bool SetBlocking(intptr_t fd); Why not club these ...

7 years, 9 months ago (2013-03-01 01:24:56 UTC) #2

Tom Ball

https://codereview.chromium.org/12380032/diff/1/runtime/bin/socket.h File runtime/bin/socket.h (right): https://codereview.chromium.org/12380032/diff/1/runtime/bin/socket.h#newcode55 runtime/bin/socket.h:55: static bool SetBlocking(intptr_t fd); On 2013/03/01 01:24:56, siva wrote: ...

7 years, 9 months ago (2013-03-01 18:33:04 UTC) #3

Tom Ball

7 years, 9 months ago (2013-03-01 18:33:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r19334 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12380032: Added Socket::SetBlocking() and Socket::SetNonBlocking(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages