Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 12380031: Fixed debugger stacktrace generation that failed a VM assertion. (Closed)

Created:
7 years, 9 months ago by Tom Ball
Modified:
7 years, 9 months ago
Reviewers:
siva, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fixed debugger stacktrace generation that failed a VM assertion. Added LocalVarDescriptors.ToCString(), which is just used when debugging debugger issues, and is not referenced by any public APIs. Committed: https://code.google.com/p/dart/source/detail?r=19255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M runtime/vm/debugger.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +32 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Ball
7 years, 9 months ago (2013-02-28 18:40:15 UTC) #1
hausner
lgtm
7 years, 9 months ago (2013-02-28 18:48:12 UTC) #2
Tom Ball
7 years, 9 months ago (2013-02-28 20:45:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19255 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698