Issue 12380029: Keep track of closing socket, in WebSocket, so we don't write once the socket is closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12380029: Keep track of closing socket, in WebSocket, so we don't write once the socket is closed. (Closed)

Created:
7 years, 9 months ago by Anders Johnsen

Modified:
7 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Keep track of closing socket, in WebSocket, so we don't write once the socket is closed. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19248

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -0 lines)			Patch
M	sdk/lib/io/http_impl.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/io/websocket_impl.dart	View	1	4 chunks	+16 lines, -0 lines	0 comments	Download
M	tests/standalone/io/web_socket_test.dart	View		2 chunks	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/12380029/diff/1/sdk/lib/io/websocket_impl.dart File sdk/lib/io/websocket_impl.dart (right): https://codereview.chromium.org/12380029/diff/1/sdk/lib/io/websocket_impl.dart#newcode565 sdk/lib/io/websocket_impl.dart:565: _processor.closed(); As discussed offline there should probably be ...

7 years, 9 months ago (2013-02-28 17:15:24 UTC) #2

Anders Johnsen

https://codereview.chromium.org/12380029/diff/1/sdk/lib/io/websocket_impl.dart File sdk/lib/io/websocket_impl.dart (right): https://codereview.chromium.org/12380029/diff/1/sdk/lib/io/websocket_impl.dart#newcode565 sdk/lib/io/websocket_impl.dart:565: _processor.closed(); On 2013/02/28 17:15:24, Søren Gjesse wrote: > As ...

7 years, 9 months ago (2013-02-28 17:19:47 UTC) #3

Anders Johnsen

7 years, 9 months ago (2013-02-28 17:20:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r19248 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12380029: Keep track of closing socket, in WebSocket, so we don't write once the socket is closed. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages