Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 12380015: Fix for issue 8311. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for issue 8311. Fix bad state in done-handler of event-transform-stream Committed: https://code.google.com/p/dart/source/detail?r=19215

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M sdk/lib/async/stream.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/async/stream_transform_test.dart View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 9 months ago (2013-02-28 11:51:55 UTC) #1
floitsch
LGTM.
7 years, 9 months ago (2013-02-28 12:05:55 UTC) #2
Lasse Reichstein Nielsen
7 years, 9 months ago (2013-02-28 12:18:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19215 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698