Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 12379085: Revert "Move Arrays class to private library." (Closed)

Created:
7 years, 9 months ago by floitsch
Modified:
7 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Revert "Move Arrays class to private library." This reverts commit 19375. Committed: https://code.google.com/p/dart/source/detail?r=19420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -236 lines) Patch
M runtime/lib/byte_array.dart View 34 chunks +38 lines, -57 lines 0 comments Download
M runtime/lib/growable_array.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M runtime/lib/simd128.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M samples/swarm/swarm_ui_lib/observable/observable.dart View 1 chunk +1 line, -14 lines 0 comments Download
D sdk/lib/_collection_dev/arrays.dart View 1 chunk +0 lines, -94 lines 0 comments Download
M sdk/lib/_collection_dev/collection_dev.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_collection_dev/collection_dev_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/interceptors.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 3 chunks +20 lines, -27 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 1 chunk +26 lines, -0 lines 0 comments Download
A + sdk/lib/collection/arrays.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/collection.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/collection/collection_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/collection/collections.dart View 1 chunk +4 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
TBR.
7 years, 9 months ago (2013-03-04 21:27:24 UTC) #1
floitsch
7 years, 9 months ago (2013-03-04 21:27:43 UTC) #2
floitsch
Committed patchset #1 manually as r19420 (presubmit successful).
7 years, 9 months ago (2013-03-04 21:27:51 UTC) #3
srdjan
7 years, 9 months ago (2013-03-04 21:28:12 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698