Issue 12379039: Add exception information to help diagnose issue 8865

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12379039: Add exception information to help diagnose issue 8865 (Closed)

Created:
7 years, 9 months ago by Søren Gjesse

Modified:
7 years, 9 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add exception information to help diagnose issue 8865 Might we be getting a SocketIOException? If soshould it be wrapped in a HttpException? TBR=ajohnsen@google.com BUG=https://code.google.com/p/dart/issues/detail?id=8865 Committed: https://code.google.com/p/dart/source/detail?r=19277

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tests/standalone/io/http_content_length_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Committed patchset #1 manually as r19277 (presubmit successful).

7 years, 9 months ago (2013-03-01 08:07:05 UTC) #2

Anders Johnsen

Didn't you just mark this as flaky? If so, it won't print stdout/stderr. lgtm.

7 years, 9 months ago (2013-03-01 08:10:55 UTC) #3

Søren Gjesse

7 years, 9 months ago (2013-03-01 08:17:09 UTC) #4

Message was sent while issue was closed.

On 2013/03/01 08:10:55, Anders Johnsen wrote:
> Didn't you just mark this as flaky? If so, it won't print stdout/stderr.
> 
> lgtm.

Darn - yes I did. Will re-enable.

Expand Messages | Collapse Messages