Issue 12378040: Add missing certificate getter on HttpClientResponse and add a regression test.

Issue 12378040: Add missing certificate getter on HttpClientResponse and add a regression test. (Closed)

Created:
7 years, 9 months ago by Mads Ager (google)

Modified:
7 years, 9 months ago

Reviewers:
Bill Hesse, Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add missing certificate getter on HttpClientResponse and add a regression test. Also cleaned up some internal type annotations to avoid type warnings. R=whesse@google.com,sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19302

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix long line. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
M	sdk/lib/io/http.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/io/http_impl.dart	View		5 chunks	+9 lines, -5 lines	0 comments	Download
M	tests/standalone/io/https_client_certificate_test.dart	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/12378040/diff/1/tests/standalone/io/https_client_certificate_test.dart File tests/standalone/io/https_client_certificate_test.dart (right): https://codereview.chromium.org/12378040/diff/1/tests/standalone/io/https_client_certificate_test.dart#newcode34 tests/standalone/io/https_client_certificate_test.dart:34: return response.reduce(<int>[], (message, data) => message..addAll(data)); Long line.

7 years, 9 months ago (2013-03-01 12:25:48 UTC) #3

Mads Ager (google)

https://codereview.chromium.org/12378040/diff/1/tests/standalone/io/https_client_certificate_test.dart File tests/standalone/io/https_client_certificate_test.dart (right): https://codereview.chromium.org/12378040/diff/1/tests/standalone/io/https_client_certificate_test.dart#newcode34 tests/standalone/io/https_client_certificate_test.dart:34: return response.reduce(<int>[], (message, data) => message..addAll(data)); On 2013/03/01 12:25:48, ...

7 years, 9 months ago (2013-03-01 12:31:25 UTC) #4

Mads Ager (google)

7 years, 9 months ago (2013-03-01 12:32:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r19302 (presubmit successful).

Expand Messages | Collapse Messages