Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Issue 12377082: Recognize more list factories. Recognizing list factories (Array, Bytearrays, etc) allows the type … (Closed)

Created:
7 years, 9 months ago by srdjan
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Recognize more list factories. Recognizing list factories (Array, Bytearrays, etc) allows the type and range to be determined. Add byte array factories to the list of recognzied factories and intrinsify them early. If not intrinisified they may be inlined and not recognized. Keeping the recognition at API level is more stable as internal implementation may change. Committed: https://code.google.com/p/dart/source/detail?r=19422

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -49 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 6 chunks +33 lines, -17 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 4 chunks +8 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 3 chunks +26 lines, -21 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 2 2 chunks +15 lines, -3 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 2 3 chunks +55 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 2 3 chunks +66 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 2 3 chunks +55 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 2 3 chunks +66 lines, -0 lines 0 comments Download
M runtime/vm/symbols.h View 1 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
7 years, 9 months ago (2013-03-04 19:19:31 UTC) #1
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/12377082/diff/3001/runtime/vm/intrinsifier.h File runtime/vm/intrinsifier.h (left): https://codereview.chromium.org/12377082/diff/3001/runtime/vm/intrinsifier.h#oldcode104 runtime/vm/intrinsifier.h:104: V(_Float32Array, _new, Float32Array_new, 109944959) \ I wonder if ...
7 years, 9 months ago (2013-03-04 19:39:28 UTC) #2
srdjan
Added intrinsification of _new. https://codereview.chromium.org/12377082/diff/3001/runtime/vm/intrinsifier.h File runtime/vm/intrinsifier.h (left): https://codereview.chromium.org/12377082/diff/3001/runtime/vm/intrinsifier.h#oldcode104 runtime/vm/intrinsifier.h:104: V(_Float32Array, _new, Float32Array_new, 109944959) \ ...
7 years, 9 months ago (2013-03-04 21:37:07 UTC) #3
srdjan
7 years, 9 months ago (2013-03-04 21:38:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r19422 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698