Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 12377055: pkg/unittest: simplify guardAsync (Closed)

Created:
7 years, 9 months ago by kevmoo-old
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

There are features needed for unittest impl that don't make a lot of sense for users. BUG=https://code.google.com/p/dart/issues/detail?id=8878 Committed: https://code.google.com/p/dart/source/detail?r=19347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M pkg/unittest/lib/unittest.dart View 6 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo-old
PTAL
7 years, 9 months ago (2013-03-01 21:48:05 UTC) #1
gram
lgtm. Did you verify that no other test in the tree uses the finally parameter ...
7 years, 9 months ago (2013-03-02 00:22:31 UTC) #2
kevmoo-old
The only user was impl in unittest. I walked through the grep of the other ...
7 years, 9 months ago (2013-03-02 00:27:31 UTC) #3
gram
7 years, 9 months ago (2013-03-02 01:08:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19347 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698