Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 12377041: Update FF status. (Closed)

Created:
7 years, 9 months ago by kasperl
Modified:
7 years, 9 months ago
Reviewers:
ricow1, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tests/html/html.status View 1 chunk +1 line, -2 lines 3 comments Download

Messages

Total messages: 6 (0 generated)
kasperl
7 years, 9 months ago (2013-03-01 08:37:56 UTC) #1
kasperl
There are a whole bunch of uncategorized failures here. I'll try to investigate what's going ...
7 years, 9 months ago (2013-03-01 08:39:01 UTC) #2
kasperl
Committed patchset #1 manually as r19279 (presubmit successful).
7 years, 9 months ago (2013-03-01 08:39:16 UTC) #3
ricow1
LGTM https://codereview.chromium.org/12377041/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/12377041/diff/1/tests/html/html.status#newcode286 tests/html/html.status:286: element_types_test/constructors: Fail do we know why this fails, ...
7 years, 9 months ago (2013-03-01 08:39:34 UTC) #4
kasperl
https://codereview.chromium.org/12377041/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/12377041/diff/1/tests/html/html.status#newcode286 tests/html/html.status:286: element_types_test/constructors: Fail On 2013/03/01 08:39:34, ricow1 wrote: > do ...
7 years, 9 months ago (2013-03-01 08:41:47 UTC) #5
blois
7 years, 9 months ago (2013-03-02 02:05:09 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/12377041/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/12377041/diff/1/tests/html/html.status#newcod...
tests/html/html.status:286: element_types_test/constructors: Fail
On 2013/03/01 08:41:47, kasperl wrote:
> On 2013/03/01 08:39:34, ricow1 wrote:
> > do we know why this fails, or should we slap a please Triage on this?
> 
> I'll add 'please triage' on a lot of these unless I can find any obvious
reason
> why they are failing. 

I realize this CL was reverted, but please CC me on changes like this in the
future. 

Pretty much all changes to the status of the supported tests should be
accompanied by changes to our doc attributes which indicate what functionality
is available and where.

All 'supported' tests are essentially already triaged- these indicate that a
feature is not supported by a platform. I've been intending to clean up this
file to separate the supported checks from the test failures, and will get on
that ASAP.

We spent a lot of time trying to stabilize the tests in M3, I realize that there
is still a lot of work to do but I'm really hoping we're past the point where we
need to add test exclusions for no known reason.

Powered by Google App Engine
This is Rietveld 408576698