Issue 12377032: Do not inline List factory if a non-constant argument is passed in order to prevent non-optimal cod…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12377032: Do not inline List factory if a non-constant argument is passed in order to prevent non-optimal cod… (Closed)

Created:
7 years, 9 months ago by srdjan

Modified:
7 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, Vyacheslav Egorov (Google), Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not inline List factory if a non-constant argument is passed in order to prevent non-optimal code being generated. This is a temporary fix until we have found a better solution (maybe introduce a high-performance ? operator once its definition settles). Committed: https://code.google.com/p/dart/source/detail?r=19267

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph_inliner.cc	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comment. -Ivan https://codereview.chromium.org/12377032/diff/3001/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): https://codereview.chromium.org/12377032/diff/3001/runtime/vm/flow_graph_inliner.cc#newcode649 runtime/vm/flow_graph_inliner.cc:649: // TODO(srdjan): Fix inlining of ...

7 years, 9 months ago (2013-02-28 23:22:31 UTC) #2

srdjan

https://codereview.chromium.org/12377032/diff/3001/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): https://codereview.chromium.org/12377032/diff/3001/runtime/vm/flow_graph_inliner.cc#newcode649 runtime/vm/flow_graph_inliner.cc:649: // TODO(srdjan): Fix inlining of List. factory. On 2013/02/28 ...

7 years, 9 months ago (2013-02-28 23:31:01 UTC) #3

srdjan

7 years, 9 months ago (2013-02-28 23:31:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r19267 (presubmit successful).

Expand Messages | Collapse Messages