Issue 12377017: Use enum instead of bool parameter in IL instructions to indicate if a store barrier is needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12377017: Use enum instead of bool parameter in IL instructions to indicate if a store barrier is needed. (Closed)

Created:
7 years, 9 months ago by Florian Schneider

Modified:
7 years, 9 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Use enum instead of bool parameter in IL instructions to indicate if a store barrier is needed. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=19232

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -13 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	2 chunks	+10 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	6 chunks	+14 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Florian Schneider

7 years, 9 months ago (2013-02-28 14:30:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19232 (presubmit successful).