Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1237573002: Remove functions white-listed for use of try-finally and switch, add JS_SET_CURRENT_ISOLATE. (Closed)

Created:
5 years, 5 months ago by karlklose
Modified:
5 years, 5 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove functions white-listed for use of try-finally and switch, add JS_SET_CURRENT_ISOLATE. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/04dacd24f40340761366af6d2a2a08f22901704e

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Change CURRENT_ISOLATE to STATIC_STATE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -828 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 2 chunks +11 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +1 line, -13 lines 0 comments Download
M pkg/pkg.status View 2 chunks +1 line, -5 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 3 chunks +1 line, -382 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +7 lines, -16 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 chunk +0 lines, -9 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +6 lines, -52 lines 0 comments Download
M tests/language/language_dart2js.status View 3 chunks +41 lines, -60 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +5 lines, -285 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
asgerf
LGTM. Btw I did not get the usual email from Rietveld about this; I just ...
5 years, 5 months ago (2015-07-13 13:24:45 UTC) #1
karlklose
On 2015/07/13 13:24:45, asgerf wrote: > LGTM. > > Btw I did not get the ...
5 years, 5 months ago (2015-07-14 07:19:27 UTC) #2
karlklose
5 years, 5 months ago (2015-07-14 08:26:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
04dacd24f40340761366af6d2a2a08f22901704e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698