Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 12374060: Adding Node.insertAllBefore (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 9 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding Node.insertAllBefore Also addressing some late feedback from Node.nodes.addAll. BUG=8882 Committed: https://code.google.com/p/dart/source/detail?r=19593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -32 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 4 chunks +29 lines, -3 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 5 chunks +34 lines, -3 lines 0 comments Download
M tests/html/node_test.dart View 1 chunk +61 lines, -25 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 2 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 9 months ago (2013-03-02 02:11:23 UTC) #1
sra1
lgtm
7 years, 9 months ago (2013-03-02 02:22:44 UTC) #2
blois
7 years, 9 months ago (2013-03-07 00:44:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19593 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698