Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1940)

Issue 12374027: Fix the pkg/http multipart test to avoid a race condition. (Closed)

Created:
7 years, 9 months ago by nweiz
Modified:
7 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix the pkg/http multipart test to avoid a race condition. BUG=8843 Committed: https://code.google.com/p/dart/source/detail?r=19263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M pkg/http/test/multipart_test.dart View 2 chunks +20 lines, -13 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
You were right, it was my code causing the flakiness.
7 years, 9 months ago (2013-02-28 19:57:21 UTC) #1
Bob Nystrom
LGTM.
7 years, 9 months ago (2013-02-28 23:12:21 UTC) #2
nweiz
7 years, 9 months ago (2013-02-28 23:16:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19263 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698