Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 12374016: Remove custom remove method from HTMLSelectElement in dart.idl. The members are suppressed in htmlr… (Closed)

Created:
7 years, 9 months ago by Mads Ager (google)
Modified:
7 years, 9 months ago
Reviewers:
Anton Muhin, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove custom remove method from HTMLSelectElement in dart.idl. The members are suppressed in htmlrenamer.py and it is confusing to have them in dart.idl just to be suppressed somewhere else. R=antonm@google.com,blois@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/dom/idl/dart/dart.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
7 years, 9 months ago (2013-02-28 14:18:35 UTC) #1
Anton Muhin
lgtm
7 years, 9 months ago (2013-02-28 15:30:54 UTC) #2
Mads Ager (google)
7 years, 9 months ago (2013-02-28 16:07:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19242 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698