Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 12374011: Fix bug 8841 by running the closure analyzer before compiling a field. (Closed)

Created:
7 years, 9 months ago by ngeoffray
Modified:
7 years, 9 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, floitsch, Alan Knight
Visibility:
Public.

Description

Fix bug 8841 by running the closure analyzer before compiling a field. Committed: https://code.google.com/p/dart/source/detail?r=19204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -15 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 chunk +21 lines, -15 lines 0 comments Download
A tests/language/closure_in_field_initializer_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 9 months ago (2013-02-28 07:52:52 UTC) #1
kasperl
LGTM.
7 years, 9 months ago (2013-02-28 08:05:27 UTC) #2
ngeoffray
7 years, 9 months ago (2013-02-28 08:09:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19204 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698