Issue 1236973002: Pass an absolute package root to the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1236973002: Pass an absolute package root to the VM. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Pass an absolute package root to the VM. This is helpful for subprocesses to be able to spawn Dart with Platform.executableArguments and have that work regardless of the working directory. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/b1ca2b72b1b23bf5a0bf16bf816d684cc809b3a2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	lib/src/executable.dart	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://codereview.chromium.org/1236973002/diff/1/lib/src/executable.dart File lib/src/executable.dart (right): https://codereview.chromium.org/1236973002/diff/1/lib/src/executable.dart#newcode122 lib/src/executable.dart:122: /// working directory. "//" instead of "///".

5 years, 5 months ago (2015-07-14 17:41:20 UTC) #2

nweiz

https://codereview.chromium.org/1236973002/diff/1/lib/src/executable.dart File lib/src/executable.dart (right): https://codereview.chromium.org/1236973002/diff/1/lib/src/executable.dart#newcode122 lib/src/executable.dart:122: /// working directory. On 2015/07/14 17:41:19, Bob Nystrom wrote: ...

5 years, 5 months ago (2015-07-14 19:57:54 UTC) #4

nweiz

5 years, 5 months ago (2015-07-14 19:58:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b1ca2b72b1b23bf5a0bf16bf816d684cc809b3a2 (presubmit successful).

Expand Messages | Collapse Messages