Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1236933004: "The "now" option forces the linker to resolve all dynamic symbols at program start time and the "r… (Closed)

Created:
5 years, 5 months ago by rmacnak
Modified:
5 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

"The "now" option forces the linker to resolve all dynamic symbols at program start time and the "relro" option marks the Global Offset Table (GOT) as read-only. Together, these options prevent attacks that try to overwrite libc function pointers in the GOT." BUG=http://b/22479195 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/248f21688744943761c16932708d18db07e90235

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/gyp/configurations_make.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 5 months ago (2015-07-15 21:47:56 UTC) #2
siva
lgtm
5 years, 5 months ago (2015-07-15 21:53:00 UTC) #3
rmacnak
5 years, 5 months ago (2015-07-16 16:39:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
248f21688744943761c16932708d18db07e90235 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698