Fix crash in code coverage generation.

Fix crash in code coverage generation.

Separate the higher- and lower-level cleanup steps during isolate shutdown. The former (currently only code coverage and timeline) may need to allocate, but the latter should not. Add assertions.

(cc:zra, who's working on clean shutdown)

BUG=23848
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/ee492893089edc0068e5cfcaeaf70f00b73d3901

[koda, 2015-07-17 15:18:30]

koda@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2015-07-17 17:23:27]

LGTM w/c

https://codereview.chromium.org/1236913006/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/1236913006/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:1503: if ((timeline_event_recorder_ != NULL) &&
Move emitting the timeline events to the first group as well.

[koda, 2015-07-17 17:45:31]

https://codereview.chromium.org/1236913006/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/1236913006/diff/1/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:1503: if ((timeline_event_recorder_ != NULL) &&
On 2015/07/17 17:23:26, rmacnak wrote:
> Move emitting the timeline events to the first group as well.

Done.

[koda, 2015-07-17 20:06:26]

Committed patchset #2 (id:20001) manually as
ee492893089edc0068e5cfcaeaf70f00b73d3901 (presubmit successful).