Issue 1236433003: Revert "Update Analysis Server highlight API and implementation."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1236433003: Revert "Update Analysis Server highlight API and implementation." (Closed)

Created:
5 years, 5 months ago by Brian Wilkerson

Modified:
5 years, 5 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org, scheglov

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Update Analysis Server highlight API and implementation." This reverts commit 739847402ba02e225117fefe8c2e5111bc75c255. Rolling the wire protocol API version forward caused existing clients to break, so we're rolling it back until we can find a backward compatible way of adding the new functionality. R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/10b7db100ffec216aa09d1d7816f1c59677eb70b

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+262 lines, -575 lines)			Patch
M	pkg/analysis_server/doc/api.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/analysis_server.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/computer/computer_highlights.dart	View	10 chunks	+30 lines, -76 lines	0 comments	Download
M	pkg/analysis_server/lib/src/generated_protocol.dart	View	6 chunks	+60 lines, -160 lines	0 comments	Download
M	pkg/analysis_server/test/analysis/notification_highlights_test.dart	View	9 chunks	+91 lines, -156 lines	0 comments	Download
M	pkg/analysis_server/test/integration/analysis/highlights_test.dart	View	3 chunks	+17 lines, -19 lines	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View	4 chunks	+29 lines, -69 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/generated/java/types/HighlightRegionType.java	View	2 chunks	+17 lines, -57 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	3 chunks	+15 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

5 years, 5 months ago (2015-07-13 16:50:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
10b7db100ffec216aa09d1d7816f1c59677eb70b (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages