Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1236413002: Make sure NodeValidator uriAttributes aren't passed as attributes (Closed)

Created:
5 years, 5 months ago by Alan Knight
Modified:
5 years, 5 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make sure NodeValidator uriAttributes aren't passed as attributes WIP BUG= R=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/cd8c569632c602a76f6e765d8f0b6e730757e8c3

Patch Set 1 #

Patch Set 2 : Formatting #

Patch Set 3 : And regenerate libraries after formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -51 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 5 chunks +22 lines, -17 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 2 5 chunks +22 lines, -17 lines 0 comments Download
M tests/html/node_validator_important_if_you_suppress_make_the_bug_critical_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/dom/src/NodeValidatorBuilder.dart View 1 5 chunks +22 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Alan Knight
5 years, 5 months ago (2015-07-15 22:18:15 UTC) #2
Alan Knight
ping
5 years, 5 months ago (2015-07-17 20:47:23 UTC) #3
terry
LGTM
5 years, 5 months ago (2015-07-17 21:09:17 UTC) #4
Alan Knight
5 years, 5 months ago (2015-07-17 21:12:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
cd8c569632c602a76f6e765d8f0b6e730757e8c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698