Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1236403006: Upgrade to the new test package. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/http_multi_server@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
D .status View 1 chunk +0 lines, -18 lines 0 comments Download
A .test_config View 1 chunk +5 lines, -0 lines 2 comments Download
M pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M test/http_multi_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 5 months ago (2015-07-16 00:26:09 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/1236403006/diff/1/.test_config File .test_config (right): https://codereview.chromium.org/1236403006/diff/1/.test_config#newcode3 .test_config:3: "platforms": ["vm"] How about using TestOn() for this ...
5 years, 5 months ago (2015-07-16 15:39:10 UTC) #2
nweiz
https://codereview.chromium.org/1236403006/diff/1/.test_config File .test_config (right): https://codereview.chromium.org/1236403006/diff/1/.test_config#newcode3 .test_config:3: "platforms": ["vm"] On 2015/07/16 15:39:10, Bob Nystrom wrote: > ...
5 years, 5 months ago (2015-07-16 20:22:51 UTC) #3
nweiz
5 years, 5 months ago (2015-07-16 20:23:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
341db813dc54b08e18b50d0b34436ea42fbd1a10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698