dart2js: More documentation for embedded globals and properties.

dart2js: More documentation for embedded globals and shared property names.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/547a0c4c0447dcdebf7748ca9e1de88e4f04fcd3

[floitsch, 2015-07-14 16:50:11]

floitsch@google.com changed reviewers:
+ sigmund@google.com

[floitsch, 2015-07-14 16:50:11]

I have to run, which is why the three properties don't have documentation yet.

I will document them in a separate CL.

[Siggi Cherem (dart-lang), 2015-07-15 00:14:33]

This is fantastic! thanks Florian!

lgtm

https://codereview.chromium.org/1236033006/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart (right):

https://codereview.chromium.org/1236033006/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart:36: /// This
embedded global is used by the runtime when computing rti.
nit: rti => RTI

I assume RTI means runtime type information? I haven't seen where this is
defined, so it might be helpful to define the acronym either here or somewhere
else in the compiler (somewhere more discoverable? in RuntimeTypes?)

https://codereview.chromium.org/1236033006/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart:56: /// A JS map
from tags to interceptor class.
what do we mean by tags here? markers in the classes? HTML tags?

https://codereview.chromium.org/1236033006/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart:61: /// A JS map
from tags to booleans.
same here

https://codereview.chromium.org/1236033006/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart:72: /// This
function uses the [ISOLATE_TAG] (below) to construct a name that is
not for right now, but if TAG here has a different meaning than TAG above
(assuming the one above is HTML_TAG), it might be worth renaming this. One idea
would be to call it ISOLATE_MARKER?

[floitsch, 2015-07-15 15:59:07]

https://codereview.chromium.org/1236033006/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart (right):

https://codereview.chromium.org/1236033006/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart:36: /// This
embedded global is used by the runtime when computing rti.
On 2015/07/15 00:14:33, Siggi Cherem (dart-lang) wrote:
> nit: rti => RTI
> 
> I assume RTI means runtime type information? I haven't seen where this is
> defined, so it might be helpful to define the acronym either here or somewhere
> else in the compiler (somewhere more discoverable? in RuntimeTypes?)

added it here.

FYI: currently the RTI is usually a pointer to the constructor of the class.
Things get more complicated with generic types...
It is abstracted away, though, so different emitters can do it differently, and
Stephen has a plan to replace it with  something else, too.

https://codereview.chromium.org/1236033006/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart:56: /// A JS map
from tags to interceptor class.
On 2015/07/15 00:14:33, Siggi Cherem (dart-lang) wrote:
> what do we mean by tags here? markers in the classes? HTML tags?

done.

https://codereview.chromium.org/1236033006/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart:61: /// A JS map
from tags to booleans.
On 2015/07/15 00:14:33, Siggi Cherem (dart-lang) wrote:
> same here

Done.

https://codereview.chromium.org/1236033006/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart:72: /// This
function uses the [ISOLATE_TAG] (below) to construct a name that is
On 2015/07/15 00:14:33, Siggi Cherem (dart-lang) wrote:
> not for right now, but if TAG here has a different meaning than TAG above
> (assuming the one above is HTML_TAG), it might be worth renaming this. One
idea
> would be to call it ISOLATE_MARKER?

Added a TODO.

[floitsch, 2015-07-16 12:57:35]

Committed patchset #2 (id:20001) manually as
547a0c4c0447dcdebf7748ca9e1de88e4f04fcd3 (presubmit successful).