dart2js: Use the correct hashes for deferred code in the startup-emitter.

dart2js: Use the correct hashes for deferred code in the startup-emitter.

Also support source-maps.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/5d30039cccaa38af3c100653ccc769b0bde3f06b

[floitsch, 2015-07-13 16:33:08]

floitsch@google.com changed reviewers:
+ herhut@google.com

[floitsch, 2015-07-22 15:13:12]

floitsch@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-07-23 00:01:10]

lgtm

https://codereview.chromium.org/1235973004/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/startup_emitter/deferred_fragment_hash.dart
(right):

https://codereview.chromium.org/1235973004/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/deferred_fragment_hash.dart:13:
void setHash(String hash) {
any reason why not make this `set hash`?

https://codereview.chromium.org/1235973004/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/deferred_fragment_hash.dart:18:
String get value {
I was initially surprised that we are not following the typical getter/setter
pair here. Then I realized the subtlety of the extra quotes and that this is
overriding `value` from js.DeferredString. Maybe add @override to make it
obvious?

https://codereview.chromium.org/1235973004/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart (right):

https://codereview.chromium.org/1235973004/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart:190:
writeDeferredFragments(deferredFragmentsCode);
will writeDefferredFragments be used anywhere else?

If not, maybe just pass down the map of Fragment->FragmentHash and set the hash
directly there.

https://codereview.chromium.org/1235973004/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart:254: if
(compiler.deferredMapUri != null) {
any reason we need to emit the map here in the js_emitter? This feels similar to
dump-info, in that it could either be emitted directly by the deferredLoadTask
or the compiler itself.

[floitsch, 2015-07-29 18:00:28]

https://codereview.chromium.org/1235973004/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/startup_emitter/deferred_fragment_hash.dart
(right):

https://codereview.chromium.org/1235973004/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/deferred_fragment_hash.dart:13:
void setHash(String hash) {
On 2015/07/23 00:01:10, Siggi Cherem (dart-lang) wrote:
> any reason why not make this `set hash`?

Because this should only happen once as a deliberate action. Having a setter
feels like it's ok to use it like a normal property and set it multiple times.

https://codereview.chromium.org/1235973004/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/deferred_fragment_hash.dart:18:
String get value {
On 2015/07/23 00:01:10, Siggi Cherem (dart-lang) wrote:
> I was initially surprised that we are not following the typical getter/setter
> pair here. Then I realized the subtlety of the extra quotes and that this is
> overriding `value` from js.DeferredString. Maybe add @override to make it
> obvious?

added comment and done.

https://codereview.chromium.org/1235973004/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart (right):

https://codereview.chromium.org/1235973004/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart:190:
writeDeferredFragments(deferredFragmentsCode);
On 2015/07/23 00:01:10, Siggi Cherem (dart-lang) wrote:
> will writeDefferredFragments be used anywhere else?
> 
> If not, maybe just pass down the map of Fragment->FragmentHash and set the
hash
> directly there.

Whenever possible I try to return the result of a function as return-value. I
really don't like when functions have side-effects that aren't obvious (from
their name).
I could rename the function to `writeDeferredFragmentsAndFillHunkMap` but in
this case we can return the map, so there isn't any need for it.

https://codereview.chromium.org/1235973004/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart:254: if
(compiler.deferredMapUri != null) {
On 2015/07/23 00:01:10, Siggi Cherem (dart-lang) wrote:
> any reason we need to emit the map here in the js_emitter? This feels similar
to
> dump-info, in that it could either be emitted directly by the deferredLoadTask
> or the compiler itself.

No reason. A lot of this code has been copied/inspired by the full-emitter.
I guess it makes sense to keep it in this file, since we emit almost everything
here. (Note that the startup-emitter doesn't support dump-info yet).

For now I moved it to `emitProgram`. The `writeMainFragment` was not the right
place.

[floitsch, 2015-08-03 15:46:43]

Committed patchset #5 (id:80001) manually as
5d30039cccaa38af3c100653ccc769b0bde3f06b (presubmit successful).