Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1235963002: Add a tool to generate a graph of tasks and their dependencies. (Closed)

Created:
5 years, 5 months ago by Paul Berry
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a tool to generate a graph of tasks and their dependencies. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/f9fec69a79e9e6afb477109b32c99a091be59134

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -0 lines) Patch
A pkg/analyzer/tool/task_dependency_graph.dart View 1 chunk +150 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 5 months ago (2015-07-13 14:54:06 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1235963002/diff/1/pkg/analyzer/tool/task_dependency_graph.dart File pkg/analyzer/tool/task_dependency_graph.dart (right): https://codereview.chromium.org/1235963002/diff/1/pkg/analyzer/tool/task_dependency_graph.dart#newcode19 pkg/analyzer/tool/task_dependency_graph.dart:19: * of exactly one task. One more todo: ...
5 years, 5 months ago (2015-07-13 15:01:19 UTC) #3
Paul Berry
5 years, 5 months ago (2015-07-13 16:42:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f9fec69a79e9e6afb477109b32c99a091be59134 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698