Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1235843003: Make subtype test cache stub shared between isolates. (Closed)

Created:
5 years, 5 months ago by Florian Schneider
Modified:
5 years, 5 months ago
Reviewers:
koda
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make subtype test cache stub shared between isolates. Also remove an the unused pp paramters from LoadIsolate on ARM64. BUG= R=koda@google.com Committed: https://github.com/dart-lang/sdk/commit/141d6bdcd24c345f2c01136144144bd86a39a82b

Patch Set 1 #

Total comments: 2

Patch Set 2 : added back comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -31 lines) Patch
M runtime/vm/assembler_arm.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/assembler_arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_arm64.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/vm/class_table.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M runtime/vm/stub_code.h View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 10 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 5 months ago (2015-07-13 10:26:48 UTC) #2
koda
lgtm https://codereview.chromium.org/1235843003/diff/1/runtime/vm/class_table.h File runtime/vm/class_table.h (right): https://codereview.chromium.org/1235843003/diff/1/runtime/vm/class_table.h#newcode181 runtime/vm/class_table.h:181: static intptr_t table_offset() { Comment belongs here now.
5 years, 5 months ago (2015-07-13 12:58:56 UTC) #3
Florian Schneider
https://codereview.chromium.org/1235843003/diff/1/runtime/vm/class_table.h File runtime/vm/class_table.h (right): https://codereview.chromium.org/1235843003/diff/1/runtime/vm/class_table.h#newcode181 runtime/vm/class_table.h:181: static intptr_t table_offset() { On 2015/07/13 12:58:56, koda wrote: ...
5 years, 5 months ago (2015-07-13 13:06:12 UTC) #4
Florian Schneider
5 years, 5 months ago (2015-07-13 13:42:21 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
141d6bdcd24c345f2c01136144144bd86a39a82b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698