Issue 1235823009: Upgrade to the new test runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1235823009: Upgrade to the new test runner. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/path@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Upgrade to the new test runner. R=rnystrom@google.com Committed: https://github.com/dart-lang/path/commit/81cf95e9964a232f5902d48645bfea487093d3ef

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -35 lines)			Patch
M	.gitignore	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	.status	View	1 chunk	+0 lines, -21 lines	0 comments	Download
A	.test_config	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pubspec.yaml	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/browser_test.dart	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	test/io_test.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	test/path_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/posix_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/relative_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/url_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/windows_test.dart	View	2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://codereview.chromium.org/1235823009/diff/1/test/windows_test.dart File test/windows_test.dart (left): https://codereview.chromium.org/1235823009/diff/1/test/windows_test.dart#oldcode16 test/windows_test.dart:16: group('separator', () { Oops.

5 years, 5 months ago (2015-07-16 15:42:16 UTC) #2

nweiz

5 years, 5 months ago (2015-07-16 20:27:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
81cf95e9964a232f5902d48645bfea487093d3ef (presubmit successful).

Expand Messages | Collapse Messages