Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1235463004: dart2js: Take named arguments into account (again) when naming one-shot interceptors. (Closed)

Created:
5 years, 5 months ago by herhut
Modified:
5 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Take named arguments into account (again) when naming one-shot interceptors. R=karlklose@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/374f9e3941f94b9750cce8e103470c6db4ae0c84

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix date #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2 lines) Patch
M pkg/compiler/lib/src/js_backend/minify_namer.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A tests/compiler/dart2js_extra/interceptor_named_arguments_test.dart View 1 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
herhut
5 years, 5 months ago (2015-07-10 12:20:31 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/1235463004/diff/1/tests/compiler/dart2js_extra/interceptor_named_arguments_test.dart File tests/compiler/dart2js_extra/interceptor_named_arguments_test.dart (right): https://codereview.chromium.org/1235463004/diff/1/tests/compiler/dart2js_extra/interceptor_named_arguments_test.dart#newcode1 tests/compiler/dart2js_extra/interceptor_named_arguments_test.dart:1: // Copyright (c) 2013, the Dart project authors. ...
5 years, 5 months ago (2015-07-10 12:23:35 UTC) #2
herhut
https://codereview.chromium.org/1235463004/diff/1/tests/compiler/dart2js_extra/interceptor_named_arguments_test.dart File tests/compiler/dart2js_extra/interceptor_named_arguments_test.dart (right): https://codereview.chromium.org/1235463004/diff/1/tests/compiler/dart2js_extra/interceptor_named_arguments_test.dart#newcode1 tests/compiler/dart2js_extra/interceptor_named_arguments_test.dart:1: // Copyright (c) 2013, the Dart project authors. Please ...
5 years, 5 months ago (2015-07-10 12:32:32 UTC) #3
herhut
5 years, 5 months ago (2015-07-10 12:33:05 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
374f9e3941f94b9750cce8e103470c6db4ae0c84 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698