Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 123533002: Capture and print times for the isInstanceOf method (Closed)

Created:
6 years, 11 months ago by Brian Wilkerson
Modified:
6 years, 11 months ago
Reviewers:
scheglov, jwren, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Capture and print times for the isInstanceOf method. I'm not sure how to test these changes without re-running the translator, but I'll be happy to do so if someone can show me how. Jaime: will it break anything to write an additional piece of timing information? R=danrubel@google.com, jwren@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=31441

Patch Set 1 #

Patch Set 2 : Duplicated update of java_core #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -101 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 chunk +57 lines, -50 lines 0 comments Download
M pkg/analyzer/bin/analyzer.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 1 chunk +57 lines, -50 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Brian Wilkerson
6 years, 11 months ago (2014-01-02 22:35:03 UTC) #1
scheglov
LGTM
6 years, 11 months ago (2014-01-02 22:44:21 UTC) #2
danrubel
lgtm
6 years, 11 months ago (2014-01-03 16:04:11 UTC) #3
jwren
On 2014/01/03 16:04:11, danrubel wrote: > lgtm LGTM
6 years, 11 months ago (2014-01-03 17:23:53 UTC) #4
jwren
On 2014/01/03 16:04:11, danrubel wrote: > lgtm LGTM
6 years, 11 months ago (2014-01-03 17:23:54 UTC) #5
Brian Wilkerson
6 years, 11 months ago (2014-01-03 17:28:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r31441 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698