Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 12351006: Change MultipartFile.fromFile to MultipartFile.fromPath in pkg/http. (Closed)

Created:
7 years, 9 months ago by nweiz
Modified:
7 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change MultipartFile.fromFile to MultipartFile.fromPath in pkg/http. This also makes pkg/http warning-clean. Committed: https://code.google.com/p/dart/source/detail?r=19185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -67 lines) Patch
M pkg/http/lib/src/multipart_file.dart View 2 chunks +9 lines, -6 lines 0 comments Download
M pkg/http/lib/src/utils.dart View 1 chunk +0 lines, -59 lines 0 comments Download
M pkg/http/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/http/test/multipart_test.dart View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 9 months ago (2013-02-27 23:27:55 UTC) #1
Bob Nystrom
LGTM
7 years, 9 months ago (2013-02-27 23:29:51 UTC) #2
nweiz
7 years, 9 months ago (2013-02-27 23:36:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698