Remove the timeout for downloading packages.

Remove the timeout for downloading packages.

This causes a substantial amount of pain, and doesn't seem to really
help anyone. It's rare to have the connection with the server go
completely dead without actually closing.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub/commit/e47ecbc74d6b62a5fe5c9d00029b15a62e0642b6

[Bob Nystrom, 2015-07-14 00:48:42]

lgtm

https://codereview.chromium.org/1235013002/diff/1/lib/src/http.dart
File lib/src/http.dart (right):

https://codereview.chromium.org/1235013002/diff/1/lib/src/http.dart#newcode92
lib/src/http.dart:92: request.url.host == "storage.googleapis.com")) {
Indent this another +4.

https://codereview.chromium.org/1235013002/diff/1/lib/src/http.dart#newcode105
lib/src/http.dart:105: throw new PubHttpException(await
http.Response.fromStream(streamedResponse));
Long line.

https://codereview.chromium.org/1235013002/diff/1/lib/src/io.dart
File lib/src/io.dart (right):

https://codereview.chromium.org/1235013002/diff/1/lib/src/io.dart#newcode860
lib/src/io.dart:860: Future<bool> extractTarGz(Stream<List<int>> stream, String
destination) {
This <bool> is bogus here. Yay for null being "bool" and not catching this in
checked mode. :(

https://codereview.chromium.org/1235013002/diff/1/lib/src/io.dart#newcode923
lib/src/io.dart:923: Future<bool> _extractTarGzWindows(Stream<List<int>> stream,
Might as well remove it here too.

[nweiz, 2015-07-14 01:21:35]

Code review changes

[nweiz, 2015-07-14 01:21:40]

https://codereview.chromium.org/1235013002/diff/1/lib/src/http.dart
File lib/src/http.dart (right):

https://codereview.chromium.org/1235013002/diff/1/lib/src/http.dart#newcode92
lib/src/http.dart:92: request.url.host == "storage.googleapis.com")) {
On 2015/07/14 00:48:42, Bob Nystrom wrote:
> Indent this another +4.

Done.

https://codereview.chromium.org/1235013002/diff/1/lib/src/http.dart#newcode105
lib/src/http.dart:105: throw new PubHttpException(await
http.Response.fromStream(streamedResponse));
On 2015/07/14 00:48:42, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/1235013002/diff/1/lib/src/io.dart
File lib/src/io.dart (right):

https://codereview.chromium.org/1235013002/diff/1/lib/src/io.dart#newcode860
lib/src/io.dart:860: Future<bool> extractTarGz(Stream<List<int>> stream, String
destination) {
On 2015/07/14 00:48:42, Bob Nystrom wrote:
> This <bool> is bogus here. Yay for null being "bool" and not catching this in
> checked mode. :(

Done.

https://codereview.chromium.org/1235013002/diff/1/lib/src/io.dart#newcode923
lib/src/io.dart:923: Future<bool> _extractTarGzWindows(Stream<List<int>> stream,
On 2015/07/14 00:48:42, Bob Nystrom wrote:
> Might as well remove it here too.

Done.

[nweiz, 2015-07-14 01:21:50]

Committed patchset #2 (id:20001) manually as
e47ecbc74d6b62a5fe5c9d00029b15a62e0642b6 (presubmit successful).