Issue 1234803008: Fix for issue 23834 (https://github.com/dart-lang/sdk/issues/23834)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1234803008: Fix for issue 23834 (https://github.com/dart-lang/sdk/issues/23834) (Closed)

Created:
5 years, 5 months ago by siva

Modified:
5 years, 5 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix for issue 23834 (https://github.com/dart-lang/sdk/issues/23834) Script snapshots do not use VM isolate object indexes and hence we should not be accounting for max_vm_isolate_object_id. This is related to the fix done in https://github.com/dart-lang/sdk/issues/23647 BUG=23834 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/969005dfe6963eb363307fec3cbac305e39fcbb4

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -30 lines)			Patch
M	runtime/vm/dart_api_message.h	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	runtime/vm/dart_api_message.cc	View	9 chunks	+7 lines, -20 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

siva

5 years, 5 months ago (2015-07-15 23:56:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
969005dfe6963eb363307fec3cbac305e39fcbb4 (presubmit successful).