Issue 1234733002: Properly shorten library names on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1234733002: Properly shorten library names on Windows. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/stack_trace@master

Target Ref:
refs/heads/master

Visibility:
Public.

Properly shorten library names on Windows. The library getter may be URL- or path-formatted, so to make Windows work we need to split on both kinds of separator. R=rnystrom@google.com Committed: https://github.com/dart-lang/stack_trace/commit/761540c83dd4583ff5ff273a5bcd4aeef5aa508e

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -3 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/src/frame.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/src/trace.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

nweiz

On 2015/07/13 17:11:31, Bob Nystrom wrote: > Tests? This is causing the existing tests to ...

5 years, 5 months ago (2015-07-13 20:09:13 UTC) #4

nweiz

5 years, 5 months ago (2015-07-13 20:14:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
761540c83dd4583ff5ff273a5bcd4aeef5aa508e (presubmit successful).