Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 123463009: Add another setRange test (Closed)

Created:
6 years, 11 months ago by sra1
Modified:
6 years, 11 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add another setRange test This test demonstrates that the underlying buffer may have a different element size to the views on the buffer. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31569

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M tests/lib/lib.status View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/lib/typed_data/setRange_5_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
The VM implementation crashes with: Unhandled exception: RangeError: index (7) must be in the range ...
6 years, 11 months ago (2014-01-07 03:40:24 UTC) #1
srdjan
LGTM
6 years, 11 months ago (2014-01-07 19:22:00 UTC) #2
sra1
6 years, 11 months ago (2014-01-07 20:28:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31569 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698